-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experiment: Expanded contentOnly
/ write mode List block editing
#65836
Draft
talldan
wants to merge
3
commits into
trunk
Choose a base branch
from
try/flexible-content-only-lists
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Block] List
Affects the List Block
[Feature] Block Locking
The API allowing for the ability to lock/unlock blocks
labels
Oct 2, 2024
talldan
changed the title
Experiment: content only list editing
Experiment: Expanded Oct 2, 2024
contentOnly
/ write mode List block editing
Size Change: +101 B (+0.01%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] List
Affects the List Block
[Feature] Block Locking
The API allowing for the ability to lock/unlock blocks
[Type] Enhancement
A suggestion for improvement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
See #65778
Experiments with allowing list items to be added/removed and outdented/indented in content only mode
How?
Adds a
contentOnlyInsertion
property touseInnerBlocksProps
. (maybeallowContentOnlyInsertion
is a better name)When this is present, it bypasses some of the usual logic for blocks in the
canInsertBlockTypes
andcanRemoveBlock
selectors.Notes
quote
that accept any inner block type, we might want to limit what can be inserted in contentOnly mode. Perhaps an option is an API likeallowContentOnlyInsertion: [ 'core/paragraph' ]
useInnerBlocksProps
the right place to declare this or should it be in the block.json? WithuseInnerBlocksProps
it can at least be made private to start with.Testing Instructions
Also try with contentOnly locked group, here's a code snippet that can be pasted into a code editor:
Screenshots or screencast
Kapture.2024-10-02.at.17.42.49.mp4